Skip to content

Add log meesage in both program for indexing & analytics - #232

Merged
coachchucksol merged 11 commits into
masterfrom
ak/log
Aug 7, 2025
Merged

Add log meesage in both program for indexing & analytics#232
coachchucksol merged 11 commits into
masterfrom
ak/log

Conversation

@aoikurokawa

@aoikurokawa aoikurokawa commented May 5, 2025

Copy link
Copy Markdown
Collaborator

@aoikurokawa aoikurokawa changed the title Add log Add log meesage in both program for indexing & analytics May 5, 2025
@codecov

codecov Bot commented May 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.41558% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.05%. Comparing base (af95116) to head (3ce8768).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
restaking_program/src/cooldown_ncn_vault_ticket.rs 0.00% 6 Missing ⚠️
...king_program/src/cooldown_operator_vault_ticket.rs 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   85.05%   85.05%   -0.01%     
==========================================
  Files          91       91              
  Lines        9529     9606      +77     
==========================================
+ Hits         8105     8170      +65     
- Misses       1424     1436      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aoikurokawa
aoikurokawa marked this pull request as ready for review May 5, 2025 09:58
@aoikurokawa aoikurokawa mentioned this pull request May 5, 2025
Closed
coachchucksol
coachchucksol suggested changes Aug 6, 2025
View reviewed changes

@coachchucksol coachchucksol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement: verbose flag

Comment thread vault_program/src/add_delegation.rs Outdated
.delegate(amount)?;

msg!(
"ADD DELEGATION: Vault {} delegating {} tokens to Operator {}",

@coachchucksol coachchucksol Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment out - high throughput

@aoikurokawa aoikurokawa Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 99823a6

Comment thread vault_program/src/burn_withdrawal_ticket.rs Outdated
.collect();
drop(vault_staker_withdrawal_ticket_data);

msg!(

@coachchucksol coachchucksol Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment out - high throughput

@aoikurokawa aoikurokawa Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 99823a6

Comment thread vault_program/src/cooldown_delegation.rs Outdated
.cooldown(amount)?;
vault.delegation_state.cooldown(amount)?;

msg!(

@coachchucksol coachchucksol Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment out - high throughput

@aoikurokawa aoikurokawa Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 99823a6

Comment thread vault_program/src/enqueue_withdrawal.rs Outdated

vault.increment_vrt_enqueued_for_cooldown_amount(vrt_amount)?;

msg!(

@coachchucksol coachchucksol Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment out - high throughput

@aoikurokawa aoikurokawa Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 99823a6

Comment thread vault_program/src/mint_to.rs Outdated
return Err(VaultError::VrtOutCannotBeZero.into());
}

msg!(

@coachchucksol coachchucksol Aug 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment out - high throughput

@aoikurokawa aoikurokawa Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed 99823a6

@coachchucksol

coachchucksol commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

If we go with verbose flag - that should add in all msg! ( including the intro messages in lib.rs )

@coachchucksol
coachchucksol merged commit 1f5b318 into master Aug 7, 2025
8 of 10 checks passed
@coachchucksol
coachchucksol deleted the ak/log branch August 7, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebatsell ebatsell ebatsell approved these changes
+1 more reviewer
@coachchucksol coachchucksol coachchucksol approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logs/Events: Consider adding some basic logging for indexing & analytics

3 participants

@aoikurokawa @coachchucksol @ebatsell