CLI: Refactor jito-shank-cli to support dynamic configuration via CLI - #238
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 92 92
Lines 9667 9667
=======================================
Hits 8215 8215
Misses 1452 1452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aoikurokawa
changed the title
jito-shank-cli to support dynamic configuration via CLI
aoikurokawa
marked this pull request as ready for review
May 20, 2025 20:44
coachchucksol
suggested changes
Aug 6, 2025
| @@ -1,13 +1,13 @@ | |||
| [package] | |||
| name = "jito-shank-cli" | |||
| description = "Jito Shank CLI" | |||
Contributor
There was a problem hiding this comment.
should probably be workspace?
Collaborator
Author
There was a problem hiding this comment.
That's right! back to workspace
Contributor
There was a problem hiding this comment.
still needs to be changed back
coachchucksol
enabled auto-merge (squash)
August 7, 2025 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jito-tip-router,ncn-templateuse mostly same logic for generating IDL, so after publishingjito-shank-idlcrate, we can remove these code from each repo.