Cranker: Logging Improvements for Loki - #67
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the cranker’s observability for Loki by switching to JSON-formatted tracing output, standardizing log messages/keys, and avoiding leaking sensitive RPC URL components into logs.
Changes:
- Switched tracing subscriber output from pretty to JSON and adjusted startup/config logs (including RPC URL redaction).
- Refined runtime logging in the cranker loop and receipt processing for more consistent, query-friendly messages.
- Enabled
tracing-subscriber’sjsonfeature (with corresponding lockfile updates) and added unit tests for URL redaction.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cranker/src/main.rs | Initializes JSON tracing, logs config in key-value style, and adds redact_url + tests to reduce secret leakage. |
| cranker/src/lib.rs | Streamlines/standardizes operational logs in the main loop and receipt processing. |
| cranker/Cargo.toml | Enables tracing-subscriber JSON support. |
| Cargo.lock | Pulls in transitive deps needed for JSON tracing output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ebatsell
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.