-
Notifications
You must be signed in to change notification settings - Fork 0
Add species list view per sub-key #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8924eca
Initial plan
Copilot 9115181
Add mushroom species list feature with waarnemingen.be image support
Copilot 483f92d
no hex
jitsedesmet 80ab3ea
Merge branch 'main' into copilot/mushroom-list-ink-caps
jitsedesmet 0a3fcae
Move species list entry to a dedicated sub-key index page
Copilot ef71802
Fix nav bar position when species list has few items
Copilot e9962d8
Remove waarnemingen.be image support; expand species list quick links
Copilot 2a1acd6
Fix copyright text overflowing in species list thumbnails
Copilot fa381c1
Show photo credit as overlay in species list thumbnails
Copilot 4577b51
Remove credits prop; simplify OneZoomPicture to single creditsOverlay…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! I like the overview look. I think it can replace 'credits' entirely? Since it is used no where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in
4577b51. Removed thecreditsprop entirely —creditsOverlayis now the only prop. Updated all three call sites: the mushroom identification page passescreditsOverlay={true}, the saved page drops the oldcredits={false}(default is no credits), and the species list is unchanged.