Getting remote audio subscription and route-loudest-only work together#2356
Open
kota-yata wants to merge 10 commits intojitsi:masterfrom
Open
Getting remote audio subscription and route-loudest-only work together#2356kota-yata wants to merge 10 commits intojitsi:masterfrom
kota-yata wants to merge 10 commits intojitsi:masterfrom
Conversation
…ed, and necessary methods in AudioSubscriptionManager
kota-yata
force-pushed
the
kota/remote-as
branch
from
536c7d4 to
9ae56ce
Compare
Remote as
bgrozev
reviewed
Nov 20, 2025
Member
bgrozev
left a comment
bgrozev
left a comment
There was a problem hiding this comment.
I don't see handling of the removeAudioSubscription message implemented. I also don't see cleanup when a relay disconnects -- removing its explicit subscriptions
| override fun addAudioSubscription(message: AddAudioSubscriptionMessage): BridgeChannelMessage? { | ||
| val sourceName = message.sourceName | ||
| val ep = relay.conference.findSourceOwner(sourceName) | ||
| ep?.addAudioSubscription(message.bridgeId, message.sourceName) |
Member
There was a problem hiding this comment.
Can we log in case no ep is found?
| } else { | ||
| subscribedRemoteAudioSources[sourceName] = mutableSetOf(endpointId) | ||
| if (endpoint is RelayedEndpoint) { | ||
| // TODO: Notify relay of new explicit subscription |
Member
There was a problem hiding this comment.
There's a few of these TODOs remaining in this class
| * A message sent from one bridge to another indicating that the bridge subscribes to the source | ||
| */ | ||
| class AddAudioSubscriptionMessage( | ||
| val bridgeId: String, |
Member
There was a problem hiding this comment.
We don't need to include the bridgeId in the message, as relay connections are direct -- we always know the ID of the other side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another map to the AudioSubscriptionManager for remote subscription. An AudioSubscriptionManager then updates it according to new subscription and source addition/removal