Use FETCH_TIMEOUT_MS instead of a hardcoded 2000ms#1254
Open
jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
Open
Use FETCH_TIMEOUT_MS instead of a hardcoded 2000ms#1254jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2000ms fallback timeout in the functions HTTP handler with a configurable value read from theFETCH_TIMEOUT_MSenvironment variable.2000msif the env var is not set, preserving existing behavior.In
FunctionsHandlerMulti, when thex-request-timeout-msheader is not present on a request, the fetch timeout fell back to a hardcoded2000. This value is now read fromgetServerEnv().FETCH_TIMEOUT_MSat startup (usingparseNumberwith a default of2000), making it configurable without a code change.Fixes #1253