Hotfix/Safeguards for device number properties - #184
Merged
jjjonesjr33 merged 1 commit intoNov 30, 2025
Merged
Conversation
jjjonesjr33
approved these changes
Nov 30, 2025
jjjonesjr33
left a comment
Owner
There was a problem hiding this comment.
Looks good, nice hot fix @FeliGoblin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change:
User was getting a TypeError when VolumeConverter was trying to convert value
NoneThe change adds a safeguard to a bunch of device properties that should return numbers. Before, they only checked if the value exists, now it checks that it's a number.
For example:
becomes:
Closes #183 (issue)
Type of change:
Checklist:
Additional notes: