Skip to content

Add additional device info attributes - #187

Merged
jjjonesjr33 merged 2 commits into
jjjonesjr33:devfrom
natekspencer:device-info
Dec 8, 2025
Merged

Add additional device info attributes#187
jjjonesjr33 merged 2 commits into
jjjonesjr33:devfrom
natekspencer:device-info

Conversation

@natekspencer

Copy link
Copy Markdown
Contributor

Proposed change:

Adds serial number and mac address to device info.
Petlibro DeviceInfo

Closes #186 (issue)

Type of change:

  • New device.
  • Bug fix (non-breaking change which fixes an issue).
  • New feature or enhancement (non-breaking change which adds functionality).
  • Documentation only.
  • Other (please explain).

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement guidlines before submitting my request.
  • If applicable, I have tested my code for new features & regressions on the latest version of Home Assistant.

Additional notes:

@jjjonesjr33 jjjonesjr33 self-assigned this Dec 6, 2025
@jjjonesjr33 jjjonesjr33 added the Enhancement New feature or request label Dec 6, 2025
@github-project-automation github-project-automation Bot moved this to To triage in Petlibro Dec 6, 2025
@jjjonesjr33 jjjonesjr33 added this to the Other milestone Dec 6, 2025
@jjjonesjr33
jjjonesjr33 self-requested a review December 6, 2025 03:55
@jjjonesjr33

Copy link
Copy Markdown
Owner

@natekspencer The update is looking solid. At this point, the only adjustment I’d suggest is removing the legacy MAC Address and Device SN sensors from each device. Let me know if that’s something you can handle, or if I should open a ticket for tracking.

@jjjonesjr33 jjjonesjr33 added the In review Pending review label Dec 6, 2025

@jjjonesjr33 jjjonesjr33 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change, I like it!

@natekspencer

Copy link
Copy Markdown
Contributor Author

@natekspencer The update is looking solid. At this point, the only adjustment I’d suggest is removing the legacy MAC Address and Device SN sensors from each device. Let me know if that’s something you can handle, or if I should open a ticket for tracking.

I'll adjust that this weekend

@natekspencer

Copy link
Copy Markdown
Contributor Author

@jjjonesjr33 I've removed the sensors so they are no longer created and also removed the translations for them.

@jjjonesjr33 jjjonesjr33 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets give it a test 👍🏻

@github-project-automation github-project-automation Bot moved this from To triage to In review in Petlibro Dec 8, 2025
@jjjonesjr33
jjjonesjr33 merged commit cf31668 into jjjonesjr33:dev Dec 8, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Petlibro Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request In review Pending review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add serial number and mac address to an entity's DeviceInfo attribute

2 participants