fix(#140): increase rotation cooldown and add rotation lock - #251
Open
dennismdejong wants to merge 1 commit into
Open
fix(#140): increase rotation cooldown and add rotation lock#251dennismdejong wants to merge 1 commit into
dennismdejong wants to merge 1 commit into
Conversation
…k to prevent concurrent rotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Problem: Automations calling
rotate_food_bowlorset_plate_positionfollowed byset_manual_feed_now(open lid) could cause unexpected extra plate rotations. The rotation cooldown of 0.6s was too short for the device to settle between steps.Fix:
ROTATE_COOLDOWNfrom 0.6s to 2.0s to let the device settle between rotation steps_rotatinglock to prevent concurrent rotation calls (defensive, logs a warning if rotation is already in progress)set_manual_feed_now: warn ifstopis called without a validmanualFeedId