Skip to content

fix(#258): stop calling .json() on parsed cleaning/filter reset responses - #264

Open
SAY-5 wants to merge 1 commit into
jjjonesjr33:devfrom
SAY-5:fix/fountain-reset-buttons
Open

fix(#258): stop calling .json() on parsed cleaning/filter reset responses#264
SAY-5 wants to merge 1 commit into
jjjonesjr33:devfrom
SAY-5:fix/fountain-reset-buttons

Conversation

@SAY-5

@SAY-5 SAY-5 commented Aug 16, 2026

Copy link
Copy Markdown

Proposed change:

set_cleaning_reset and set_filter_reset still call .json() on the value returned by session.post, but PetLibroSession.request already returns the parsed data payload (and raises PetLibroAPIError on a non-zero code), so pressing Cleaning Reset or Filter Reset on the Dockstream fountain fails with 'dict' object has no attribute 'json'. Return the parsed payload directly, same as the other reset calls after #201.

Closes #258

Type of change:

  • New device.
  • Bug fix (non-breaking change which fixes an issue).
  • New feature or enhancement (non-breaking change which adds functionality).
  • Documentation only.
  • Other (please explain).

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement guidlines before submitting my request.
  • If applicable, I have tested my code for new features & regressions on the latest version of Home Assistant.

Additional notes:

I do not own a PLWF105, so this is verified against the request path in api.py rather than on hardware.

…reset responses

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cleaning Reset / Filter Reset buttons fail with "'dict' object has no attribute 'json'"

1 participant