fix(#258): stop calling .json() on parsed cleaning/filter reset responses - #264
Open
SAY-5 wants to merge 1 commit into
Open
fix(#258): stop calling .json() on parsed cleaning/filter reset responses#264SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…reset responses Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change:
set_cleaning_resetandset_filter_resetstill call.json()on the value returned bysession.post, butPetLibroSession.requestalready returns the parseddatapayload (and raisesPetLibroAPIErroron a non-zero code), so pressing Cleaning Reset or Filter Reset on the Dockstream fountain fails with'dict' object has no attribute 'json'. Return the parsed payload directly, same as the other reset calls after #201.Closes #258
Type of change:
Checklist:
Additional notes:
I do not own a PLWF105, so this is verified against the request path in
api.pyrather than on hardware.