Calculate possible code-actions kinds dynamically#871
Open
nemethf wants to merge 1 commit into
Open
Conversation
I thought the server must reply with a subset of the client's list of codeActionKind during the initialization. But it's clearly not the case. The typescript-language-server returns these [1]: ["source.fixAll.ts" "source.removeUnused.ts" "source.addMissingImports.ts" ...] The clangd server returns these [2]: ["quickfix" "refactor" "info"] (Additionally, in the current code there is a mismatch between what Eglot initially sent and the completing read arguemnt of eglot-code-actions. "source" and "refactor" is missing from `eglot-code-actions'. Was this intentional?) Now, Eglot plays safe, and offers the union of the two lists as possible completions in `eglot-code-actions'. [1]: #847 (comment) [2]: #860
|
Any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought the server must reply with a subset of the client's list of
codeActionKind during the initialization. But it's clearly not the case.
The typescript-language-server returns these 1:
["source.fixAll.ts" "source.removeUnused.ts" "source.addMissingImports.ts" ...]
The clangd server returns these 2:
["quickfix" "refactor" "info"]
(Additionally, in the current code there is a mismatch between what
Eglot initially sent and the completing read argument of
eglot-code-actions. "source" and "refactor" is missing from
`eglot-code-actions'. Was this intentional?)
Now, Eglot plays safe, and offers the union of the two lists as
possible completions in `eglot-code-actions'.