Fix two bugs#1
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe extension now uses Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Extension
participant FS as File System
participant Shell as Shell/exec
Client->>Extension: /skill: request (with ctx.cwd)
Extension->>FS: discover SKILL.md using ctx.cwd
FS-->>Extension: SKILL.md path + contents
Extension->>Shell: run interpolation in ctx.cwd (env may include CLAUDE_SKILL_DIR)
Shell-->>Extension: interpolation output
Extension-->>Client: response
sequenceDiagram
participant Tool as Read Tool
participant Extension
participant FS as File System
participant Parser
Tool->>Extension: returns read target path
Extension->>FS: resolve path against ctx.cwd and read full SKILL.md
FS-->>Extension: file contents or error
Extension->>Parser: parse frontmatter / allowed-tools
alt allowed
Extension->>Shell: run Bash interpolation in ctx.cwd
Shell-->>Extension: result
else not allowed
Extension-->>Tool: skip interpolation
end
Extension-->>Tool: final processed output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@index.ts`:
- Line 4: Resolve the tool's input path against the execution cwd before
re-reading the file: compute a resolvedPath = path.resolve(ctx.cwd,
event.input.path) (add resolve to the import if missing) and use that
resolvedPath in the readFileSync call instead of event.input.path so the
frontmatter check reads the correct file when process.cwd() differs from
ctx.cwd; ensure any later uses that re-read or reference the same file (e.g.,
where readFileSync is called and any subsequent file operations tied to
event.input.path) use resolvedPath for consistency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
I decided to upstream another change to set |
Thanks for this extension. I encountered two issues while using it with a skill I originally built for Claude Code:
This PR fixes both issues.
In the interest of full disclosure, the code changes were done by GPT-5.4 Mini (with review from me).
Summary by CodeRabbit