Skip to content

refactor: missing fixes for standards violations#43

Merged
zrosenbauer merged 8 commits intomainfrom
refactor/fix-standards-violations
Mar 10, 2026
Merged

refactor: missing fixes for standards violations#43
zrosenbauer merged 8 commits intomainfrom
refactor/fix-standards-violations

Conversation

@zrosenbauer
Copy link
Copy Markdown
Member

Caution

Fill out the description or you won't get reviewed!


‼️ Breaking Changes ‼️


📗 Description

☑️ Checklist

  • I've labeled the type, i.e. type: feature or type: bugfix
  • I've labeled the semver, i.e. semver: major, semver: minor or semver: patch
  • This change adds tests for new/changed/fixed functionality & doesn't decrease the test coverage
  • The correct base branch is being used, if not main

zrosenbauer and others added 7 commits March 5, 2026 23:20
Replace `as` type assertions with type annotations, type guards, and
documented exceptions. Replace `try/catch` blocks with `attempt` and
`attemptAsync` from es-toolkit. Replace multi-branch if/else chains
with ts-pattern `match` expressions. Rename `redactPaths` to
`REDACT_PATHS`. Document intentional mutation and throw exceptions.

Closes #12, #15, #18, #20, #21, #33

Co-Authored-By: Claude <noreply@anthropic.com>
@zrosenbauer zrosenbauer marked this pull request as draft March 10, 2026 19:37
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 03dc355d-eb5d-4517-877e-d4a9df13f073

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/fix-standards-violations

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude <noreply@anthropic.com>
@zrosenbauer zrosenbauer marked this pull request as ready for review March 10, 2026 19:47
@zrosenbauer zrosenbauer merged commit 84f7ed6 into main Mar 10, 2026
2 checks passed
@zrosenbauer zrosenbauer deleted the refactor/fix-standards-violations branch March 10, 2026 19:47
@zrosenbauer zrosenbauer changed the title Refactor/fix standards violations refactor: missing fixes for standards violations Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant