Fix various bugs across kernel module, CI, scripts and Python package#469
Open
VVAT3R wants to merge 1 commit into
Open
Fix various bugs across kernel module, CI, scripts and Python package#469VVAT3R wants to merge 1 commit into
VVAT3R wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of fixes
Kernel module:
Makefile: Use correctvariable for `depmod` (was using undefined)dkms.conf: ReplaceDKMS_VERSIONplaceholder with real version1.0.0Python package:
setup.cfg: FixPyQT6→PyQt6(wrong casing breaks pip resolution)Scripts:
fan_control.sh: Remove hardcoded author home path; uselegion_clifrom PATH insteadtest_kernel_reload.sh: Remove spurious#!/bin/bashembedded inside theforloopCI:
build.yml,build_PR.yml,manual_test.yaml: Fixtest_kenel→test_kerneltypo (references non-existent file)extra.yaml: Add missing colon toworkflow_dispatchtriggerOther:
.github/ pull_request_template.md→.github/pull_request_template.md(leading space prevented GitHub from recognizing it)