Open
Conversation
Contributor
Author
|
@johnmichel Is there any chance you can have a look at this PR? It has been a while. |
|
Why you want to remove them? |
|
Removing obsolete libs from the detector makes web archives people sad. |
Contributor
Author
|
The motivations are:
|
|
+1 on not removing deprecated libraries. This information is useful as it lets us know of websites without outdated dependencies and/or security issues. It would actually be useful to have a special icon next to the library to denote its deprecated. For the purposes of this PR perhaps we could turn this into an option where the user can choose to load or not load deprecated libraries? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove no-longer maintained/deprecated libraries
/cc @johnmichel