Updated scripts to be compatible with firefox#177
Open
frandemona wants to merge 2 commits intojohnmichel:mainfrom
Open
Updated scripts to be compatible with firefox#177frandemona wants to merge 2 commits intojohnmichel:mainfrom
frandemona wants to merge 2 commits intojohnmichel:mainfrom
Conversation
Owner
@frandemona I'll pull this down locally and see if it runs identically in Chrome and Firefox. If it works, I'll upload it to the Firefox Extensions site and add attribution to you. |
Author
|
@johnmichel already uploaded it https://addons.mozilla.org/en-US/firefox/addon/new-library-detector/, I can add you as an owner with your firefox email account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't try it out on chrome with these changes but I suppose it will work correctly.
Thanks for this great extension!
Do you mind if I upload it to the firefox addon store? or could you add it?