stage: fix null pointer arithmetic in stage_insert_chunk()#1417
Open
PatriciaBucataru wants to merge 1 commit intojonas:masterfrom
Open
stage: fix null pointer arithmetic in stage_insert_chunk()#1417PatriciaBucataru wants to merge 1 commit intojonas:masterfrom
PatriciaBucataru wants to merge 1 commit intojonas:masterfrom
Conversation
to and last_unchanged_line were used in pointer arithmetic before the null check on to at line 338. If to is NULL, computing to - view->line is undefined behaviour per C11 6.5.6. Moved the pointer arithmetic after the null check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to and last_unchanged_line were used in pointer arithmetic before the null check on to at line 338. If to is NULL, computing to - view->line is undefined behaviour per C11 6.5.6.
Moved the pointer arithmetic after the null check.