Skip to content

fix: address provider review feedback - #2

Merged
jonschumaker merged 1 commit into
mainfrom
feat/gitlab-provider
Aug 5, 2026
Merged

fix: address provider review feedback#2
jonschumaker merged 1 commit into
mainfrom
feat/gitlab-provider

Conversation

@jonschumaker

Copy link
Copy Markdown
Owner

Summary

Merge the PR unraid#44 review fixes into this fork's main branch while retaining the feature branch for the upstream pull request.

Changes

  • Harden deployment staging paths, executable permissions, and signal rollback status.
  • Clean development-install temporary artifacts and verify legacy mirror provenance.
  • Fail GitHub runner startup when nested Docker never becomes ready.
  • Correct provider default-name argument scoping.
  • Improve test diagnostics, exact provider contracts, and GitLab lint preconditions.
  • Pin the Linux validation image, Ubuntu snapshot, and package versions.

Validation

  • bash tests/run-linux-checks.sh
  • clean ARM64 and AMD64 Linux validation-image builds
  • GitLab Runner configuration parse validation
  • all six upstream inline review threads resolved

Upstream tracking: unraid#44

@jonschumaker
jonschumaker merged commit 9eb1f4b into main Aug 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants