Skip to content

Add all valid file extensions for systemd units - #2101

Merged
jordansissel merged 2 commits into
jordansissel:mainfrom
fourieraudio:more-systemd-file-extensions
Nov 4, 2025
Merged

Add all valid file extensions for systemd units#2101
jordansissel merged 2 commits into
jordansissel:mainfrom
fourieraudio:more-systemd-file-extensions

Conversation

@eira-fransham

Copy link
Copy Markdown

See #2100

Adds the following to the list of valid extensions for systemd units:

  • .socket
  • .device
  • .mount
  • .automount
  • .swap
  • .target
  • .path
  • .slice
  • .scope

@eira-fransham

Copy link
Copy Markdown
Author

The error reported from the CI test appears to be unrelated to the changes, could someone with the correct permissions trigger a rerun?

@jordansissel

jordansissel commented Sep 2, 2025

Copy link
Copy Markdown
Owner

Thanks for improving FPM :-)

I agree the failure is unrelated. I don’t think re-running it would resolve it. I am OK with the tests as is and consider it a success.

I’ll see if I can get the code reviewed soon :-)

@jordansissel jordansissel left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added one comment.

Comment thread lib/fpm/package/deb.rb Outdated
@jordansissel
jordansissel merged commit 2bcdb34 into jordansissel:main Nov 4, 2025
@jordansissel

Copy link
Copy Markdown
Owner

Thank you!

Testing manually, looks good:

% bundle exec bin/fpm -s empty -t deb -n example --deb-systemd foo.asdf
Invalid package configuration: Invalid systemd unit file extension: .asdf. Expected one of: .service, .socket, .device, .mount, .automount, .swap, .target, .path, .timer, .slice, or .scope {level: :error}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants