Skip to content

Add --cpan-metacpan-api-url flag for custom MetaCPAN instances#2146

Open
NicholasBHubbard wants to merge 1 commit intojordansissel:mainfrom
NicholasBHubbard:custom-metacpan-url
Open

Add --cpan-metacpan-api-url flag for custom MetaCPAN instances#2146
NicholasBHubbard wants to merge 1 commit intojordansissel:mainfrom
NicholasBHubbard:custom-metacpan-url

Conversation

@NicholasBHubbard
Copy link
Copy Markdown
Contributor

This PR adds a new flag --cpan-metacpan-api-url, which can be used to point fpm to a custom MetaCPAN instance. Currently we already have a flag --cpan-mirror for pointing fpm to a custom CPAN mirror instead of the official CPAN. However, in the case that somebody both has a custom CPAN mirror and they are serving a custom MetaCPAN instance on top of that mirror, they need a way to point fpm at both. Without this flag, fpm will query the official MetaCPAN to resolve module metadata, but then attempt to fetch the tarball from the custom CPAN mirror. If the mirror contains modules or versions that aren't indexed by the official MetaCPAN, those lookups will fail.

@wbraswell
Copy link
Copy Markdown
Contributor

@jordansissel
Okay I know I said that we didn't think we had any more critical PRs but I spoke too soon, sorry!
However this is a relatively simple PR and I have already reviewed it as always, so please do approve it ASAP.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants