Add pendo availability guards to trackAgent calls#118
Open
novus-by-pendo[bot] wants to merge 1 commit into
Open
Add pendo availability guards to trackAgent calls#118novus-by-pendo[bot] wants to merge 1 commit into
novus-by-pendo[bot] wants to merge 1 commit into
Conversation
Both pendo.trackAgent() calls in handleMessageSubmit and sendMessageMutation.onSuccess are now guarded with typeof pendo !== 'undefined' to prevent runtime errors when the Pendo script is not loaded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendo.trackAgent("agent_response", ...)call withtypeof pendo !== 'undefined'by folding the check into the existingif (newMessage.role === 'assistant')conditionpendo.trackAgent("prompt", ...)call inhandleMessageSubmitwith atypeof pendo !== 'undefined'guard blockProblem
PR #115 added both
pendo.trackAgent()calls without the safety guards that were described in its PR body. Without these guards, aReferenceErroris thrown at runtime whenever the Pendo script fails to load (e.g. in development environments or when blocked by an ad-blocker), crashing the chat submit handler.Files changed
typeof pendo !== 'undefined'guards around bothpendo.trackAgent()calls