Feat dialog improvments#21
Merged
Merged
Conversation
- Create new HandoffDialog component with modern styling consistent with other dialogs - Replace inline handoff dialog in SessionControlsComponent with dedicated component - Add visual DJ transfer flow with current DJ card and target member selection - Implement real-time member preview updates when selecting handoff target - Include animated pulse arrow indicator showing transfer direction - Add impact visualization explaining handoff consequences for both users - Maintain draggable dialog functionality with modal: false setting - Follow established design system with gradients, cards, and responsive layout - Add comprehensive CSS styling for handoff-specific UI elements - Update component imports and simplify handoff logic in SessionControlsComponent
│ │ │ - Add duplicate command prevention for loadVideoById to stop repeated queueing │ │ - Update player state when loading videos to track current video properly │ │ - Fix heartbeat sync logic to only sync when video actually changes │ │ - Skip sync operations while player is still initializing │ │ - Add 3-second timeout for duplicate load command detection │ │ - Ensure video state comparison only happens when heartbeat contains video ID │ │ │ │ This fixes the issue where listeners would get stuck in endless loadVideoById │ │ loops preventing them from joining playback properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.