replaced CRLF with LF line endings - #297
Open
koenpunt wants to merge 1 commit into
Open
Conversation
Collaborator
|
Ha ha, just commented about this in another issue! |
Collaborator
|
As much as I'd love to see this, maybe we should save it until just before 1.2 drops? There may be more code submitted between now and then with the same DOS line-endings that needs to be converted by then... Whenever that is. |
Collaborator
Author
|
Hm, ok, but these are the only 4 files of 84 left with CRLF. And also git can be configured (on the client) to convert these line endings, so maybe this should be noted in the contribution section of the readme? |
Collaborator
|
Good suggestion. Let's save this for just before our 1.2 release and make notes on the contribution page. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced line endings to match with rest of the code