Skip to content

feat!: Remove unstable SIMD optimization#99

Merged
phenylshima merged 10 commits into
mainfrom
no-unstable
Aug 3, 2025
Merged

feat!: Remove unstable SIMD optimization#99
phenylshima merged 10 commits into
mainfrom
no-unstable

Conversation

@cm-ayf

@cm-ayf cm-ayf commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

BEGIN_COMMIT_OVERRIDE
feat!: Remove unstable SIMD optimization

  • features = "simd" no longer supported

END_COMMIT_OVERRIDE

@cm-ayf cm-ayf self-assigned this Jul 21, 2025
@codecov

codecov Bot commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.38%. Comparing base (506c136) to head (27a4a17).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/vocoder/mlsa.rs 88.67% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   68.43%   70.38%   +1.95%     
==========================================
  Files          39       37       -2     
  Lines        1682     1648      -34     
==========================================
+ Hits         1151     1160       +9     
+ Misses        531      488      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cm-ayf

cm-ayf commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

2つ束ねるのが速そう.3つ束ねても2つに比べてそんなに速くなさそう.

@cm-ayf cm-ayf changed the title No unstable feat: No unstable optimization Jul 21, 2025
@cm-ayf

cm-ayf commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

内積部分は頭の2つを落とす処理を書くと今より早くはならない

@cm-ayf cm-ayf marked this pull request as ready for review July 25, 2025 13:27
@cm-ayf cm-ayf requested a review from phenylshima as a code owner July 25, 2025 13:27
@cm-ayf cm-ayf changed the title feat: No unstable optimization feat!: Remove unstable SIMD optimization Jul 25, 2025
@cm-ayf

cm-ayf commented Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

Apple M2 (Armv8.2, neon)

$ git switch main && cargo bench
test bonsai        ... bench:  20,801,316.70 ns/iter (+/- 767,580.14)
test bonsai_letter ... bench:  57,772,504.10 ns/iter (+/- 8,804,701.66)
test is_bonsai     ... bench:  32,759,020.80 ns/iter (+/- 10,022,525.84)
$ git switch main && cargo bench --features simd
test bonsai        ... bench:  12,272,745.80 ns/iter (+/- 120,040.41)
test bonsai_letter ... bench:  34,358,054.20 ns/iter (+/- 1,386,455.95)
test is_bonsai     ... bench:  19,133,387.60 ns/iter (+/- 497,455.00)
$ git switch no-unstable && cargo bench
test bonsai        ... bench:  12,446,670.80 ns/iter (+/- 157,435.87)
test bonsai_letter ... bench:  34,897,683.40 ns/iter (+/- 2,214,201.69)
test is_bonsai     ... bench:  19,242,979.10 ns/iter (+/- 355,269.45)

@phenylshima

Copy link
Copy Markdown
Member

stable-x86_64-unknown-linux-gnu updated - rustc 1.88.0 (6b00bc388 2025-06-23) (from rustc 1.87.0 (17067e9ac 2025-05-09))
nightly-x86_64-unknown-linux-gnu updated - rustc 1.91.0-nightly (a65b04d7c 2025-08-02) (from rustc 1.89.0-nightly (8da623945 2025-06-13))

13th Gen Intel(R) Core(TM) i5-13500

git switch main && cargo bench
running 3 tests
test bonsai        ... bench:  16,458,765.50 ns/iter (+/- 289,340.27)
test bonsai_letter ... bench:  45,985,171.70 ns/iter (+/- 739,176.13)
test is_bonsai     ... bench:  25,486,801.60 ns/iter (+/- 120,151.92)

git switch main && RUSTFLAGS="-C target-cpu=native" cargo bench
running 3 tests
test bonsai        ... bench:  16,696,739.30 ns/iter (+/- 207,341.57)
test bonsai_letter ... bench:  46,323,621.80 ns/iter (+/- 446,965.36)
test is_bonsai     ... bench:  25,741,033.90 ns/iter (+/- 195,608.35)

git switch main && RUSTFLAGS="-C target-cpu=native" cargo bench --features simd
running 3 tests
test bonsai        ... bench:  13,735,444.50 ns/iter (+/- 22,087.25)
test bonsai_letter ... bench:  38,573,699.00 ns/iter (+/- 148,233.77)
test is_bonsai     ... bench:  21,297,797.50 ns/iter (+/- 107,323.24)

git switch no-unstable && cargo bench
running 3 tests
test bonsai        ... bench:  10,389,875.40 ns/iter (+/- 95,233.56)
test bonsai_letter ... bench:  29,519,937.60 ns/iter (+/- 908,927.55)
test is_bonsai     ... bench:  16,506,458.20 ns/iter (+/- 119,624.46)

git switch no-unstable && RUSTFLAGS="-C target-cpu=native" cargo bench
running 3 tests
test bonsai        ... bench:  17,106,528.40 ns/iter (+/- 139,770.32)
test bonsai_letter ... bench:  47,455,016.20 ns/iter (+/- 297,228.28)
test is_bonsai     ... bench:  26,435,560.50 ns/iter (+/- 196,284.83)

@phenylshima phenylshima merged commit 4392df6 into main Aug 3, 2025
11 checks passed
@phenylshima phenylshima deleted the no-unstable branch August 3, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants