Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (68.50%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
============================================
- Coverage 83.06% 82.77% -0.30%
- Complexity 442 443 +1
============================================
Files 142 142
Lines 11822 11875 +53
Branches 4462 4496 +34
============================================
+ Hits 9820 9829 +9
- Misses 1249 1289 +40
- Partials 753 757 +4
🚀 New features to boost your workflow:
|
Contributor
Author
|
This will be revisited post 1.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR which adds support for representing Generics in JPype.
In the PR we make is so that Java class with generics according to reflection can be used like
The intent is to make is so when converting to the generic type the arguments will be checked.
Currently this PR just adds the types to the class. We need to update the converters to make use of them.