Skip to content
This repository was archived by the owner on Oct 5, 2018. It is now read-only.

added support for callbacks from gogiel/delayed_paperclip#196

Open
filipepina wants to merge 4 commits intojrgifford:masterfrom
billiamsolutions:master
Open

added support for callbacks from gogiel/delayed_paperclip#196
filipepina wants to merge 4 commits intojrgifford:masterfrom
billiamsolutions:master

Conversation

@filipepina
Copy link
Copy Markdown

added the following callbacks:
post_processing_callback
pre_processing_callback
post_update_callback

requested on issue #176

@slin1202
Copy link
Copy Markdown

Do you know how to add a callback for failure?

@filipepina
Copy link
Copy Markdown
Author

@slin1202 hmmm not sure if paperclip will trigger an exception in that case... maybe checking if the style exists on "post_processing_callback" would solve your problem?
like... object.file.exists?(:style_in_question)

@slin1202
Copy link
Copy Markdown

Ah that might work, thanks!

@martinsabo
Copy link
Copy Markdown

Hi everybody (@filipepina @slin1202 ),
is there any specific reason why this PR is not merged and closed?
It is really useful feature for some usage scenarios. Can I help somehow with this?

Thanks.

@jrgifford
Copy link
Copy Markdown
Owner

jrgifford commented Mar 22, 2018 via email

@martinsabo
Copy link
Copy Markdown

@jrgifford ok, understand.

Is there any chance that you merge it when I create another PR with this feature ported to latest version (with specs and updated docs)?

@martinsabo
Copy link
Copy Markdown

@jrgifford nevermind. I have refactored myself out of need of this feature. Yet I need to say that the changes from this PR worked fine. Did not stumbled on any side-effects so far during time I have used it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants