This repository was archived by the owner on Oct 5, 2018. It is now read-only.
Making a touch on updated_at after attachment is processed#217
Open
ErvalhouS wants to merge 2 commits intojrgifford:masterfrom
Open
Making a touch on updated_at after attachment is processed#217ErvalhouS wants to merge 2 commits intojrgifford:masterfrom
ErvalhouS wants to merge 2 commits intojrgifford:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will update the
#{name}_updated_atfield after processing the file.By doing so it will enable people who uses CDNs to expire 404 errors caused by caching an access to the attachment url before the processing has finished.
WHY?
This is necessary because most CDN's configuration takes the query strings into consideration for caching, which changes when
#{name}_updated_atchanges. Changing query string will invalidate previous errors caused by not using a default "missing file" url.@jrgifford