Improve perf with benchmarks#54
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 56 39 -17
Branches 23 15 -8
=========================================
- Hits 56 39 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blakeembrey
commented
May 14, 2026
| * DIGIT = %x30-39 ; 0-9 | ||
| */ | ||
| const subtypeNameRegExp = /^[A-Za-z0-9][A-Za-z0-9!#$&^_.-]{0,126}$/; | ||
| const subtypeNameRegExp = /^[A-Za-z0-9][A-Za-z0-9!#$&^_.+-]{0,126}$/; |
Member
Author
There was a problem hiding this comment.
Noticed we allow multiple + in the typeRegExp but not when building it which breaks the ability to round trip. The RFC also allows multiple +.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a huge difference but I think there's minor improvements from switching to
.testwithout any capturing groups and doing anindexOf. Doing anindexOffirst, splitting, and doing two regexes was worse performance so keeping the combined regex.Before:
After: