feat(shelf): restore scroll position after chapter quiz - #45
Merged
Conversation
Save the shelf window scroll when opening a chapter, then restore it when returning via Back to chapters (or Back to shelf). Heading focus no longer jumps the viewport to the top. Co-authored-by: John Solly <jsolly@users.noreply.github.com>
Route Browse chapters and Back to shelf through openShelf so the saved shelf scroll is restored after reading a chapter. Harden restore timing so early layout passes cannot clear the saved position too soon. Co-authored-by: John Solly <jsolly@users.noreply.github.com>
Resolve ShelfView + constants conflicts: keep shelf scroll restore alongside hide-read UI and summary headlines from main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollYinsessionStorage(per unit).openShelf(with a chapter focus fallback) so restore is reliable without a full reload.preventScroll; saved scroll is cleared only after a successful restore.Test plan
Verification
Desktop + mobile: Browse chapters, Back to shelf, and Back to chapters all restore the pre-chapter shelf scroll; fresh home→shelf visits still start at the top.