Skip to content

Keep popovers inset from the viewport edge - #90

Merged
jsolly merged 1 commit into
mainfrom
cursor/popover-viewport-margin-6306
Jul 20, 2026
Merged

Keep popovers inset from the viewport edge#90
jsolly merged 1 commit into
mainfrom
cursor/popover-viewport-margin-6306

Conversation

@jsolly

@jsolly jsolly commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

Glossary (and other) popovers no longer sit flush against the viewport edge.

Change

Default collisionPadding={8} on shared Popover.Content so Floating UI keeps ~8px of air from screen edges when flipping/shifting.

Test plan

  • Open SSEB on /learn/propose/one-solution-staffing-price/ at 390px width → popover gapRight === 8
  • Spot-check left-edge case if easy
  • Popover still opens/closes and “Open chapter” still works

Popover inset from viewport edge

Open in Web Open in Cursor 

Default collisionPadding on Popover.Content so floating
glossary popovers (and any other popovers) leave a small gap
instead of sitting flush against the screen edge.
@jsolly
jsolly marked this pull request as ready for review July 20, 2026 12:16
@jsolly
jsolly merged commit 7df221e into main Jul 20, 2026
4 checks passed
@jsolly
jsolly deleted the cursor/popover-viewport-margin-6306 branch July 20, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants