feat: implement multipart upload functionality in jfs#7163
Open
zhijian-pro wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds multipart upload support to the jfs:// object storage implementation (used by JuiceFS CLI tooling) so large-object writes can be performed as multi-part uploads and merged server-side via CopyFileRange.
Changes:
- Advertises multipart capabilities via
Limits()and returns anUploadIDfromCreateMultipartUpload. - Implements part staging under a per-upload directory and supports streaming part uploads via
UploadPartStream. - Implements multipart completion by concatenating part files into a temporary “complete” object and renaming it into place; adds
AbortUploadcleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+432
to
+436
| func (j *juiceFS) UploadPartStream(key string, uploadID string, num int, in io.Reader) (*object.Part, error) { | ||
| err := j.Put(context.Background(), path.Join(j.partDir(key, uploadID), strconv.Itoa(num)), in) | ||
| return &object.Part{ | ||
| Num: num, | ||
| }, err |
Comment on lines
+406
to
+414
| func (j *juiceFS) Limits() object.Limits { | ||
| return object.Limits{ | ||
| IsSupportMultipartUpload: true, | ||
| IsSupportUploadPartCopy: false, | ||
| MinPartSize: 4 << 30, | ||
| MaxPartSize: 4 << 30, | ||
| MaxPartCount: 10000000, | ||
| } | ||
| } |
Comment on lines
+424
to
+430
| func (j *juiceFS) partDir(key, uploadID string) string { | ||
| name := path.Base(key) | ||
| if len(name) > 200 { | ||
| name = name[:200] | ||
| } | ||
| return fmt.Sprintf("%s/.jfs-part-%s-%s/", path.Dir(key), name, uploadID) | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.