fix path pattern for aero in Param20 benchmark - #93
Open
PratikDeoghare wants to merge 1 commit into
Open
PratikDeoghare wants to merge 1 commit into
PratikDeoghare wants to merge 1 commit into
Conversation
Contributor
Author
|
Ah wait! Aero supports 16 params max. I had locally edited branch of Aero. If this PR merges EDIT: Created an issue aerogo/aero#19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BenchmarkAero_Param20took less time thanBenchmarkAero_Param5which made mesuspicious.
BenchmarkAero_Param20is usingtwentyBrace = /{a}/{b}/...so aero treats thepath as static. This fixes the benchmark to use the pattern
twentyColon = /:a/:b/....That changes the above benchmarks to