fix: incorrect timezone for eu genshin wishes - #74
Open
Js41637 wants to merge 1 commit into
Open
Conversation
Js41637
force-pushed
the
fix/genshin-wish-eu-timestamps
branch
from
July 7, 2025 00:28
d63f3ca to
f16be12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The region check for EU was incorrect which meant all EU timestamps were being read as +8 instead of +1.
Before this gets fixed, all the wish timestamps in the DB for EU need to be fixed to offset the difference of 7 hours. I think you just need to subtract 7 hours from all official EU wishes. All EU UIDs start with 7.