Skip to content

feat: allow updating achievement set #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Js41637 merged 1 commit into from
Sep 3, 2025
Merged

feat: allow updating achievement set #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...c8f344c73a6d4d993efe9a6a000b6b3bb9d2.json → ...45c4afcdab4d3aed96767ff3ac8bd5ff2d4d.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions ...63dade727ebdc51ccf8b72656cbdb35e5467.json → ...cd24150670577a97fe9f04ad27dc9b641fc9.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion sql/achievements/update_achievement_by_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ SET
gacha = $7,
timegated = $8,
missable = $9,
impossible = $10
impossible = $10,
"set" = $11
WHERE
id = $1;

3 changes: 2 additions & 1 deletion sql/zzz/achievements/update_achievement_by_id.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ SET
gacha = $7,
timegated = $8,
missable = $9,
impossible = $10
impossible = $10,
"set" = $11
WHERE
id = $1;

2 changes: 2 additions & 0 deletions src/api/achievements/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
impossible: db_achievement.impossible,
set: db_achievement.set,
related: None,
percent: (!db_achievement.impossible)

Check warning on line 82 in src/api/achievements/mod.rs

View workflow job for this annotation

GitHub Actions / Clippy 

this method chain can be written more clearly with `if .. else ..`
.then_some(db_achievement.percent.unwrap_or_default())
.unwrap_or_default(),
}
Expand Down Expand Up @@ -147,6 +147,7 @@
timegated: Option<String>,
missable: Option<bool>,
impossible: Option<bool>,
set: Option<i32>,
}

#[utoipa::path(
Expand Down Expand Up @@ -185,6 +186,7 @@
timegated: achievement.timegated.clone(),
missable: achievement.missable,
impossible: achievement.impossible,
set: achievement.set,
};

database::achievements::update_achievement_by_id(&update_achievement, &pool).await?;
Expand Down
2 changes: 2 additions & 0 deletions src/api/gi/achievements/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
impossible: db_achievement.impossible,
set: db_achievement.set,
related: None,
percent: (!db_achievement.impossible)

Check warning on line 77 in src/api/gi/achievements/mod.rs

View workflow job for this annotation

GitHub Actions / Clippy 

this method chain can be written more clearly with `if .. else ..`
.then_some(db_achievement.percent.unwrap_or_default())
.unwrap_or_default(),
}
Expand Down Expand Up @@ -154,6 +154,7 @@
timegated: Option<String>,
missable: Option<bool>,
impossible: Option<bool>,
set: Option<i32>,
}

#[utoipa::path(
Expand Down Expand Up @@ -192,6 +193,7 @@
timegated: achievement.timegated.clone(),
missable: achievement.missable,
impossible: achievement.impossible,
set: achievement.set,
};

database::gi::achievements::update_achievement_by_id(&update_achievement, &pool).await?;
Expand Down
2 changes: 2 additions & 0 deletions src/api/zzz/achievements/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
impossible: db_achievement.impossible,
set: db_achievement.set,
related: None,
percent: (!db_achievement.impossible)

Check warning on line 77 in src/api/zzz/achievements/mod.rs

View workflow job for this annotation

GitHub Actions / Clippy 

this method chain can be written more clearly with `if .. else ..`
.then_some(db_achievement.percent.unwrap_or_default())
.unwrap_or_default(),
arcade: db_achievement.arcade,
Expand Down Expand Up @@ -156,6 +156,7 @@
timegated: Option<String>,
missable: Option<bool>,
impossible: Option<bool>,
set: Option<i32>,
}

#[utoipa::path(
Expand Down Expand Up @@ -194,6 +195,7 @@
timegated: achievement.timegated.clone(),
missable: achievement.missable,
impossible: achievement.impossible,
set: achievement.set,
};

database::zzz::achievements::update_achievement_by_id(&update_achievement, &pool).await?;
Expand Down
4 changes: 3 additions & 1 deletion src/database/achievements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ pub struct DbUpdateAchievement {
pub timegated: Option<String>,
pub missable: Option<bool>,
pub impossible: Option<bool>,
pub set: Option<i32>,
}

pub async fn update_achievement_by_id(
Expand All @@ -126,7 +127,8 @@ pub async fn update_achievement_by_id(
achievement.gacha,
achievement.timegated,
achievement.missable,
achievement.impossible
achievement.impossible,
achievement.set
)
.execute(pool)
.await?;
Expand Down
1 change: 1 addition & 0 deletions src/database/gi/achievements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
pub timegated: Option<String>,
pub missable: Option<bool>,
pub impossible: Option<bool>,
pub set: Option<i32>,

Check warning on line 106 in src/database/gi/achievements.rs

View workflow job for this annotation

GitHub Actions / Clippy 

field `set` is never read
}

pub async fn update_achievement_by_id(
Expand Down
4 changes: 3 additions & 1 deletion src/database/zzz/achievements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ pub struct DbUpdateAchievement {
pub timegated: Option<String>,
pub missable: Option<bool>,
pub impossible: Option<bool>,
pub set: Option<i32>,
}

pub async fn update_achievement_by_id(
Expand All @@ -123,7 +124,8 @@ pub async fn update_achievement_by_id(
achievement.gacha,
achievement.timegated,
achievement.missable,
achievement.impossible
achievement.impossible,
achievement.set
)
.execute(pool)
.await?;
Expand Down
Loading