📦 Bump Node.js version minimum#2716
Conversation
🦋 Changeset detectedLatest commit: 3a18fab The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if major_version < 20: | ||
| raise SystemExit( | ||
| f"MyST requires node 18, 20, or 22+; you are running node {major_version}.\n\n" | ||
| f"MyST requires Node.js >= 20; you are running node {major_version}.\n\n" |
There was a problem hiding this comment.
@rowanc1 I implemented this check for LTS-like versions.
My feeling is that rather than imposing too strict a check here, we just require a "new-enough" version, and handle any problems for specific non-LTS versions in our issue tracker.
That will make it easier to keep updating this. Long-term, we can pull this from package.json
| if major_version < 20: | ||
| raise SystemExit( | ||
| f"MyST requires node 18, 20, or 22+; you are running node {major_version}.\n\n" | ||
| f"MyST requires Node.js >= 20; you are running node {major_version}.\n\n" |
choldgraf
left a comment
choldgraf
left a comment
There was a problem hiding this comment.
Thanks for keeping this updated! The tests are happy and I love the idea of dropping support for whatever historical deps we can 😅
3 participants
Node.js 20 is the "oldest" supported Node.js runtime. We should follow suit.
This was motivated by seeing CI failures in myst-theme, which uses experimental features in Node 18. We should keep the two projects in sync.