effectively discard file entries from pattern if already mentioned#2978
Open
parmentelat wants to merge 2 commits into
Open
effectively discard file entries from pattern if already mentioned#2978parmentelat wants to merge 2 commits into
parmentelat wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4b68049 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Fixes TOC glob expansion so that files explicitly listed earlier in the TOC are not re-added when later glob patterns are expanded (addresses #2973 by matching against the resolved-path ignore list).
Changes:
- Update
patternsToFileEntriesto compare glob matches againstignoreusingresolve(path, item)so resolved ignore entries are correctly recognized. - Add a regression test ensuring explicit files are excluded from subsequent glob patterns.
- Add a changeset entry for
myst-cli.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/myst-cli/src/project/fromTOC.ts | Fix ignore filtering by resolving glob matches before checking membership in ignore. |
| packages/myst-cli/src/project/toc.pattern.spec.ts | Add regression test for excluding explicitly listed files from later patterns. |
| .changeset/eighty-dots-train.md | Add release note/version bump entry for the behavior fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+3
| --- | ||
| 'myst-cli': minor | ||
| --- |
when pattern matching and avoiding previously mentioned entries there's a need to resolve new items when searching in `ignore` because it contains resolved entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #2973
the 'ignore' context that carries already met file entries contains resolved entries, so we need to resolve the item in consideration if we want to find it in that collection