fix: tolerate failure on unconfigured favicon#2982
Merged
Conversation
Without a configured favicon, the theme falls back to fetching a default icon from mystmd.org. When that site is down (as recently happened on CI), it breaks the build. This PR adds an "optional" flag to a route, so that if that route cannot be fetched the static build simply continues. We only enable that flag for the fallback favicon.ico, since it really isn't important to have it. Also add error listeners on the binary response/write streams so a premature stream close rejects the write promise instead of hanging indefinitely.
|
Collaborator
Author
|
All PRs are currently failing CI, including mystmd, so going to merge this to get things going. Happy to revert and implement an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a configured favicon, the theme falls back to fetching a default icon from mystmd.org. When that site is down (as recently happened on CI), it breaks the build. This PR adds an "optional" flag to a route, so that if that route cannot be fetched the static build simply continues.
We only enable that flag for the fallback favicon.ico, since it really isn't important to have it.
Also add error listeners on the binary response/write streams so a premature stream close rejects the write promise instead of hanging indefinitely.