Fix #1061: Pass restart argument in _async_finish_shutdown#1100
Closed
anny0811 wants to merge 1 commit intojupyter:mainfrom
Closed
Fix #1061: Pass restart argument in _async_finish_shutdown#1100anny0811 wants to merge 1 commit intojupyter:mainfrom
anny0811 wants to merge 1 commit intojupyter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1061. I have updated the _async_finish_shutdown method in manager.py to ensure that the restart argument is correctly passed to both _async_send_kernel_sigterm() and _async_kill_kernel().