add -shell-escape flag to xelatex to fix test errors#353
add -shell-escape flag to xelatex to fix test errors#353amueller wants to merge 1 commit intojupyter:masterfrom
Conversation
|
I suspect Latex isn't installed on Travis, so those tests are skipped. I don't know enough about latex to know if this is the right fix. @michaelpacer, your input would be welcome :-) |
|
I cherry-picked this commit into #356 |
|
So everything I can find on this would suggest this as fine as anything else (in that what we're doing is allowing LaTeX to have access to the shell directly through the use of the \write18{} command). If we don't trust one of the third party libraries that we're using by default, it's probably better we run into that problem in a Travis build than on a user build. |
|
I don't know much about the way Latex works, but the concern is that the flag would allow shell commands not just by libraries we're using, but by the notebook being converted, which may be untrusted. Like our security model in the browser, it's a matter of expectations: if you explicitly ask for code to be executed, we trust that you understand the implications, but if you are opening/converting a document, you probably don't expect that action to execute arbitrary code, so you may not have checked it beforehand. As @flying-sheep suggested on #356, if someone wants to do something extra with latex, they can always nbconvert |
|
Merged #367 instead, so this should no longer be needed. |
|
Thanks for looking into it! |
Fixes #350.
I'm not entirely sure if this is the right fix. I'm also not sure why travis didn't error on this.