Allow to set SQLiteYStore's database path and document time-to-live#66
Allow to set SQLiteYStore's database path and document time-to-live#66davidbrochart merged 6 commits intojupyterlab:mainfrom
Conversation
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 274 290 +16
=====================================
- Misses 274 290 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Small nit, is it possible to hide the CodeCov warnings in the review UI? It's really noisy and makes review more difficult. |
Indeed, it's very annoying. Maybe @blink1073 knows? |
|
I think this is the setting you'd put in codecov.yaml: https://docs.codecov.com/docs/codecovyml-reference#github_checks-github-users-only |
|
Thanks, actually it's easy to hide annotations in the file view. |
dlqqq
left a comment
There was a problem hiding this comment.
Looks good, you can resolve my other conversations.
* make configurable traits local to JupyterSQLiteYStore * Lint * Set YStore config on class before instantiation Co-authored-by: David Brochart <david.brochart@gmail.com>
for more information, see https://pre-commit.ci
|
@davidbrochart This looks good. Can traits be modified at runtime? The implementation we worked on in davidbrochart#1 doesn't allow this, but this might be OK if we document it in the future. |
Traits can, but it doesn't make sense for config traits. And changing YStore types at runtime makes even less sense. |
…upyterlab#66) * Allow to set SQLiteYStore's database path and document time-to-live * No need for sqlite_ystore_factory() * make configurable traits local to JupyterSQLiteYStore (#1) * make configurable traits local to JupyterSQLiteYStore * Lint * Set YStore config on class before instantiation Co-authored-by: David Brochart <david.brochart@gmail.com> Co-authored-by: david qiu <david@qiu.dev>
This PR allows to set the database path and the document time-to-live parameters of an
SQLiteYStore. The previous way of doing it was to pass aYStoreclass, so this PR is just a way to make it easier to parameterize anSQLiteYStore. Here is a configuration example at the CLI:jupyter lab --SQLiteYStore.db_path='path/to/my.db' --SQLiteYStore.document_ttl=86400 --collaborativeBut more importantly, the default document time-to-live of an
SQLiteYStoreis nowNone(instead of 24 hours), which means that the documents' history will never be cleared. I think it is safer to do so, considering the issues that we are still trying to figure out.cc @ellisonbg @dlqqq