Skip to content

fix: enhance error handling and notifications for payment processes #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manideepk90 wants to merge 1 commit into
base: main
Choose a base branch
from
+53 −0
Open

fix: enhance error handling and notifications for payment processes #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions src/pages/payment/SavedPaymentSheet.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,17 +315,36 @@ let make = (
| Cancelled | Simulated =>
setLoading(FillingDetails)
showAlert(~errorType="warning", ~message="Payment was Cancelled")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultCancelError->HyperModule.stringifiedResStatus,
)
| Failed(error_message) =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message=error_message)
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
{
...PaymentConfirmTypes.walletError,
message: error_message,
}->HyperModule.stringifiedResStatus,
)
}
| None =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message="Technical Error")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultConfirmError->HyperModule.stringifiedResStatus,
)
}
| None =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message="Technical Error")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultConfirmError->HyperModule.stringifiedResStatus,
)
}
}

Expand Down Expand Up @@ -358,24 +377,50 @@ let make = (
| Cancelled =>
setLoading(FillingDetails)
showAlert(~errorType="warning", ~message="Cancelled")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultCancelError->HyperModule.stringifiedResStatus,
)
| Simulated => setTimeout(() => {
setLoading(FillingDetails)
showAlert(
~errorType="warning",
~message="Apple Pay is not supported in Simulated Environment",
)
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
{
...PaymentConfirmTypes.walletError,
message: "Apple Pay is not supported in Simulated Environment",
}->HyperModule.stringifiedResStatus,
)
}, 2000)->ignore
| Failed(error_message) =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message=error_message)
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
{
...PaymentConfirmTypes.walletError,
message: error_message,
}->HyperModule.stringifiedResStatus,
)
}
| None =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message="Technical Error")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultConfirmError->HyperModule.stringifiedResStatus,
)
}
| None =>
setLoading(FillingDetails)
showAlert(~errorType="error", ~message="Technical Error")
HyperModule.hyperModule.notifyWidgetPaymentResult(
nativeProp.rootTag,
PaymentConfirmTypes.defaultConfirmError->HyperModule.stringifiedResStatus,
)
}
}

Expand Down
8 changes: 8 additions & 0 deletions src/types/AllApiDataTypes/PaymentConfirmTypes.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ let formValidationError = {
code: "form_validation_failed",
message: "Payment form has validation errors. Please correct them and try again.",
}

let walletError = {
type_: "wallet_error",
status: "wallet_failed",
code: "wallet_error",
message: "An error occurred with the wallet during payment confirmation. Please try again or use a different payment method.",
}

let getACH_bank_transfer = (data: option<bank_transfer_steps_and_charges_details>) => {
switch data {
| Some(data) => data.ach_credit_transfer
Expand Down
Loading