Skip to content

fix: preserve wallet settings on accordion expand/collapse #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsaryanchauhan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: preserve wallet settings on accordion expand/collapse #4933

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4260e6
fix: preserve wallet settings on accordion expand/collapse
itsaryanchauhan Jun 7, 2026
8b7c42a
test: payinConnector - resolve strict mode locator violations for App…
itsaryanchauhan Jun 7, 2026
1cfbf36
Merge branch 'main' into fix/google-pay-wallet-persistence
itsaryanchauhan Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/fragments/ConnectorFragments/ConnectorPaymentMethodv2/Sections/OtherPaymentMethod.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,16 +226,13 @@ let make = (
updateDetails={_val => updateDetails(_val)}
paymentMethodsEnabled=temp
paymentMethod={pm}
pmtName={selectedWallet.payment_method_subtype}
pmtName={pmtData.payment_method_subtype}
closeAccordionFn
onCloseClickCustomFun={resetValues}
/>,
onItemExpandClick: () => {
onClick(pmtData, i)
},
onItemCollapseClick: () => {
resetValues()
},
renderContentOnTop: Some(
() => {
let label = switch (
Expand Down
19 changes: 4 additions & 15 deletions src/screens/Connectors/PaymentProcessor/ConnectorUIUtils/PaymentMethod.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,8 @@ module CardRenderer = {
}
}, [])

let handleBankDebitCheckboxClick = (~method) => _ => {
if paymentMethod->getPaymentMethodFromString === BankDebit {
removeOrAddMethods(method)
}
let handleCheckboxClick = (~method) => _ => {
removeOrAddMethods(method)
}

let handleOnItemExpandClick = method => () => {
Expand All @@ -393,14 +391,6 @@ module CardRenderer = {
}
}

let handleOnItemCollapseClick = method => () => {
if isSelected(method) && paymentMethod->getPaymentMethodFromString != BankDebit {
removeOrAddMethods(method)
} else {
removeSelectedWallet()
}
}

<div className="flex flex-col gap-4 border rounded-md p-6">
<div>
<RenderIf
Expand Down Expand Up @@ -598,10 +588,9 @@ module CardRenderer = {
paymentMethodsEnabled
paymentMethod
onCloseClickCustomFun={removeSelectedWallet}
pmtName={selectedWallet.payment_method_type}
pmtName={value.payment_method_type}
closeAccordionFn
/>,
onItemCollapseClick: handleOnItemCollapseClick(value),
onItemExpandClick: handleOnItemExpandClick(value),
renderContentOnTop: Some(
() => {
Expand All @@ -611,7 +600,7 @@ module CardRenderer = {
<div className="cursor-pointer">
<CheckBoxIconAdapter
isSelected={isSelected(value)}
setIsSelected={handleBankDebitCheckboxClick(~method=value)}
setIsSelected={handleCheckboxClick(~method=value)}
stopPropagationNeeded=true
/>
</div>
Expand Down
Loading