fix: address UI bugs from issue #4740#4970
Conversation
- add hover tooltips for truncated values (connector transaction id, customer id, merchant connector id, description) - show 6 payment summary cards in one row so Requires Capture is not orphaned - show 'Not Available' instead of ambiguous 'NA' for connector label - prevent api key names from wrapping to two lines - rename connector 'Disabled' column header to 'Status' Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
XyneSpaces
left a comment
There was a problem hiding this comment.
Automated Review Summary
PR: fix: address UI bugs from issue #4740
Reviewer: XyneSpaces Automation
Findings Overview
2 minor observations requiring attention on consistency.
Findings
1. Inconsistent showTooltip adoption
💡 Suggestion — The showTooltip prop was added to CopyTextCustomComp and enabled for Merchant Connector ID (ConnectorTableUtils.res) and Customer ID (CustomersEntity.res), but ConnectorInterfaceTableEntity.res still uses the component without the tooltip for the same Merchant Connector ID column.
Location: src/Interface/ConnectorInterface/ConnectorInterfaceTableEntity.res:112-114
Fix: Add showTooltip=true to the ConnectorInterfaceTableEntity.res usage for consistency across all connector ID displays.
2. Column header naming conflict potential
💡 Suggestion — The Disabled column header was renamed from "Disabled" to "Status". While this addresses the confusion mentioned in the PR description, note that there is already an "Integration status" column (mapped to colType Status). Having both a "Status" column and an "Integration status" column may still cause confusion.
Consider using "Connector Status" or "Enabled Status" to disambiguate from "Integration status" which refers to the connector's connection state.
Pre-existing Issues (Not introduced by this PR)
- The PR notes a known issue with tooltip width constraints affecting copy icon alignment. This is acknowledged and acceptable as a follow-up fix.
Verdict: ✅ Minor suggestions only — The core functionality is sound. Consider addressing the inconsistent tooltip adoption for better UX consistency.
PR Review: UI Bug Fixes (#4740)Verdict: ✅ Approve with suggestions Warnings (:warning:)1. Event Bubbling Risk in ToolTip Implementation
2. Column Header Change Blast Radius
Suggestions (:bulb:)3. Code Duplication in Conditional Rendering
let content = <div className=customTextCss> {val->React.string} </div>
{showTooltip ? <ToolTip description=val toolTipFor=content toolTipPosition=Top /> : content}4. Truncate Protection for API Key Names
5. Extract Connector Label Display Helper
let getDisplayLabel = (label: option<string>) => {
let value = label->Option.getOr("")
value->isNonEmptyString ? value : "Not Available"
}6. Description End Value Increase
7-9. Naming and Consistency Checks
|
| </RenderIf> | ||
| </div>} | ||
| toolTipPosition=ToolTip.Top | ||
| /> |
There was a problem hiding this comment.
can a video or screenshot be added for this fix?
Type of Change
Description
Addresses the UI bugs reported in #4740:
showTooltipprop toHelperComponents.CopyTextCustomCompand wrapped the truncated text in aToolTip, so hovering reveals the full value. Enabled it for Merchant Connector ID (ConnectorTableUtils.res) and Customer ID (CustomersEntity.res).EllipsisTextnow shows a tooltip with the full value when the text is truncated (only when it actually overflows).connector_labelnow defaults to an empty string instead of"NA"(PaymentInterfaceUtilsV1.res).Disabledcolumn header from "Disabled" to "Status" across all connector table entities (payment, payout, 3DS, vault, billing, tax, surcharge, PM auth, recovery, connector interface) so it no longer competes with the "Integration status" column.Namecell as awhitespace-nowrapcustom cell (KeyManagementHelper.res) for consistent row heights.OrderEntity.res) tooltip/label adjustments for the connector transaction ID / connector label.Motivation and Context
Closes #4740
How did you test it?
Manually verified the affected tables and detail screens render the tooltips, the renamed "Status" header, and non-wrapping cells.
Note
Known issue: in the copy-text cells, the
ToolTiptrigger wrapper does not carry thew-36width constraint, so the copy icon's horizontal alignment can shift with text length. Raising this PR as-is; alignment fix to follow.Where to test it?
Backend Dependency
Backend PR URL:
Feature Flag
🤖 Generated with Claude Code