refactor: Moving common functions to shared-codebase#1143
Merged
Conversation
Pradeep-kumar1202
requested review from
ArushKapoorJuspay,
PritishBudhiraja,
aritro2002,
sakksham7 and
seekshiva
as code owners
|
Review changes with Changed Files
|
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Pradeep-kumar1202
force-pushed
the
shared_codebase_priority_1
branch
from
6c458ff to
388d907
Compare
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Closed
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Pradeep-kumar1202
force-pushed
the
shared_codebase_priority_1
branch
from
c2b3659 to
72bbba4
Compare
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Pradeep-kumar1202
force-pushed
the
shared_codebase_priority_1
branch
from
72bbba4 to
d08ec7c
Compare
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Pradeep-kumar1202
force-pushed
the
shared_codebase_priority_1
branch
from
d08ec7c to
5170cd1
Compare
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
Pradeep-kumar1202
had a problem deploying
to
Testing
GitHub Actions
Failure
added 3 commits
July 31, 2025 12:37
… shared_codebase_priority_1
…y/hyperswitch-web into shared_codebase_priority_1
Pradeep-kumar1202
temporarily deployed
to
Testing
GitHub Actions
Inactive
sakksham7
approved these changes
Jul 31, 2025
PritishBudhiraja
added
the
Ready for Review
PritishBudhiraja
approved these changes
Jul 31, 2025
PritishBudhiraja
left a comment
PritishBudhiraja
left a comment
Contributor
There was a problem hiding this comment.
Will do refactoring of the code that we have written but shared code can be merged
github-actions
Bot
added
the
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Moved 10 functions to the shared codebase
How did you test it?
I have tested locally - and the code is getting compiled and tested fully
Checklist
npm run re:build