feat: sdk config api integration#1577
Conversation
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
|
please add more description and test cases images and video. Link issue. |
… feat-sdk-config-api
…itch-web into feat-sdk-config-api
0d6dc22 to
7293a73
Compare
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
|
also please check the PR title, and other S conventions which are not followed. |
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
Type of Change
Description
Extractprofile_idfromclient_secret. Changes as per feat: extract profile id from client secret #1550sdk-configsapi integrationHow did you test it? [TESTING TO BE DONE AFTER BACKEND DEPLOYMENT]
Added a console.log in DynamicFields.res file to print the sdkConfigs state.
Tried passingsdkAuthorizationin<HyperElements hyper={hyperPromise} options={{sdkAuthorization}}>,profile_idretrieved successfully andsdk-configsapi fetched properly.Tried passingprofile_idinwindow.Hyper({ publishableKey, profileId }),profile_idretrieved successfully andsdk-configsapi fetched properly.Tried passing older cs without attached profiled_id, got integration error in console.preloadSDKWithParams.Checklist
npm run re:build