feat: add payment method type PixQr#1612
Conversation
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
🚫 Missing Linked IssueHi 👋 This pull request does not appear to be linked to any open issue yet. Linking your PR to an issue helps keep the project tidy and ensures the issue is closed automatically. ✔️ How to fix this
Once linked, this check will pass automatically on your next push or when you re-run the workflow. Thanks for helping maintainers! 🙌 |
🔍 PR Review: PixQr Payment Method SupportScenario: ✅ Review SummaryClean implementation following existing patterns:
✅ Tier 1 Checks Passed
💡 Suggestion — Icon ConsistencyThe PR reuses the 💡 Suggestion — V1/V2 Parity CheckSince this is a new payment method type, verify if any corresponding changes are needed in:
If the backend already supports PixQr and this is purely SDK exposure, no additional changes needed. Verdict: ✅ Approve — Clean, consistent implementation following established patterns for adding new payment methods. |
Review SummaryStatus: ✅ No blocking issues found Findings: 0 This PR adds
Checks passed:
|
XyneSpaces
left a comment
There was a problem hiding this comment.
Web SDK review completed. Clean implementation following existing patterns for Pix payment methods.
| payment_methods_evoucher: `قسيمة إلكترونية`, | ||
| payment_methods_pix_transfer: `Pix`, | ||
| payment_methods_pix_emv_transfer: `PixEmv`, | ||
| payment_methods_pix_qr_transfer: `PixQr`, |
There was a problem hiding this comment.
🔍 Non-English locale strings use English value
The Arabic locale uses PixQr as the translation, which may not be appropriate for Arabic-speaking users. While this is consistent with PixEmv, consider whether the Brazilian Portuguese original "Pix QR" should be preserved, or if a localized description is needed.
This is a minor nit since this payment method is primarily for the Brazilian market.
| paymentMethodName: "pix_qr_transfer", | ||
| fields: [InfoElement], | ||
| icon: Some(icon("pix", ~size=26, ~width=40)), | ||
| displayName: localeString.payment_methods_pix_qr_transfer, |
There was a problem hiding this comment.
💡 Verify icon availability for pix_qr_transfer
The code reuses the pix icon for pix_qr_transfer. Verify that the same icon is appropriate for both payment method types, or if a distinct QR code variant should be added.
Type of Change
Description
Added support for a newly introduced Payment Method Type -
PixQrin the sdkHow did you test it?
Payment Link Create
Response
Checklist
npm run re:build