feat: hs external vault flow and return user support#1643
Conversation
Changed Files
|
PR Review: feat: hs external vault flow and return user supportSummaryLarge feature addition (~700 lines added across 30 files) implementing external vault integration and return user functionality. Findings[blocking] High-risk change in CardCVCElement.res — CVV validation Given this file is marked as payment-critical (handles sensitive card data), the changes need special scrutiny:
[should-fix] New atoms added to RecoilAtoms.res need default values The diff shows 44 lines added to RecoilAtoms.res. Verify each new atom has:
[should-fix] PaymentHelpers.res changes — error handling With 342 lines added, ensure:
[nit] Hyper.resi interface additions The 15 new lines in the interface file should include JSDoc/ResDoc comments explaining the new public API surface for external vault flows. RecommendationsGiven the size and sensitivity of this PR:
Review conducted by XyneSpaces automated PR reviewer |
|
dummy call to check issue API |
Type of Change
Description
Added Hyperswitch External Vault flow support and return user flow
Handled Hyperswitch Vault for Two flows, PCI and Non PCI with a build time flag
IS_PCI_COMPLIANTChanged Request Payload for HS vault in two different flows
How did you test it?
#1642
Tested all the flows via Checking
HS as External Vault - Non PCI Mode
Screen.Recording.2026-06-25.at.8.49.41.PM.mov
HS as Default Vault - PCI Mode
Screen.Recording.2026-06-25.at.8.53.39.PM.mov
Screen.Recording.2026-06-25.at.8.52.55.PM.mov
VGS External Vault -
Uploading Screen Recording 2026-06-25 at 8.54.29 PM.mov…
Checklist
npm run re:build