Skip to content

chore(deps): bump dompurify → 3.4.11 + astro → 6.4.6 (vite 6.4.3 dropped — breaks e2e)#1394

Merged
srid merged 8 commits into
masterfrom
deps/merge-vite-dompurify-astro
Jun 17, 2026
Merged

chore(deps): bump dompurify → 3.4.11 + astro → 6.4.6 (vite 6.4.3 dropped — breaks e2e)#1394
srid merged 8 commits into
masterfrom
deps/merge-vite-dompurify-astro

Conversation

@srid

@srid srid commented Jun 17, 2026

Copy link
Copy Markdown
Member

Consolidates Dependabot dependency bumps into a single PR sharing one CI run and one set of regenerated Nix pnpm-deps hashes.

Bumps

PR Package From → To Scope Status
#1392 dompurify 3.4.8 → 3.4.11 root workspace ✅ included
#1390 astro 6.1.10 → 6.4.7 (^6.4.6) /website ✅ included
#1393 vite (dev) 6.4.2 → 6.4.3 root workspace dropped

Why vite 6.4.3 was dropped

vite 6.4.3's client bundle deterministically breaks the render_recovery e2e scenario ("Regaining window focus repaints a render-stalled terminal", added in #1381) on x86_64-linux:

  • master: e2e green on linux
  • this branch with vite 6.4.3: render_recovery failed 4/4 attempts on the same warm CI box
  • darwin: passes on both

The test asserts zero xterm paints while the render loop is stalled; under vite 6.4.3 an extra paint slips through, tripping the assertion before it even verifies the focus-repaint behavior. Bisected to vite as the sole client-affecting change (lockfile delta was only vite + dompurify). vite is pinned back to 6.4.2 here; the 6.4.3 ↔ render_recovery interaction should be tracked and resolved separately before re-attempting that bump.

Notes

  • The astro Dependabot PR only touched website/package.json; its lockfile was stale, so website/pnpm-lock.yaml was regenerated (astro resolves to 6.4.7 within ^6.4.6).
  • dompurify resolves to 3.4.11 (newest within the bumped ^3.4.9 range — supersedes the 3.4.9 security fix).
  • Both fetchPnpmDeps hashes regenerated and verified deterministic via nix build --rebuild:
    • root default.nixsha256-YaxrK53rfL5nWhS29No4PqG4FOvKQXfDdUFhfgNqb/c=
    • website/default.nixsha256-RxMbH3KNdnrO050cp+nQm1TKcPAThPL+q5pmPBfxFiw=

Closes #1392
Closes #1390

🤖 Generated with Claude Code

dependabot Bot and others added 7 commits June 16, 2026 23:28
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.4.8 to 3.4.9.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@3.4.8...3.4.9)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-version: 3.4.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.4.2 to 6.4.3.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v6.4.3/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.4.3/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.4.3
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 6.1.10 to 6.4.6.
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/astro@6.4.6/packages/astro)

---
updated-dependencies:
- dependency-name: astro
  dependency-version: 6.4.6
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…y-3.4.9' into deps/merge-vite-dompurify-astro
…astro-6.4.6' into deps/merge-vite-dompurify-astro
@srid srid mentioned this pull request Jun 17, 2026
vite 6.4.3's client bundle deterministically trips the render_recovery
e2e test on x86_64-linux (master green, branch 4/4 fail, darwin green) —
an extra xterm paint slips through the stalled-render-loop window. Pin
vite back to 6.4.2 and keep only the dompurify (→3.4.11) + astro bumps.
Root pnpmDeps hash regenerated for the vite-free lockfile.

See #1394 discussion; vite 6.4.3 ↔ render_recovery to be tracked separately.
@srid srid changed the title chore(deps): merge vite 6.4.3, dompurify 3.4.9, astro 6.4.6 dependabot bumps chore(deps): bump dompurify → 3.4.11 + astro → 6.4.6 (vite 6.4.3 dropped — breaks e2e) Jun 17, 2026
@srid

srid commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

🧪 CI metrics — leased pool box

The x86_64-linux lane ran on kolu-ci-3 (dev-x86-64-linux-03) — commit fb0ede83, failed

  • Lane wall (pipeline): 2m33s
recipe duration
ci::e2e 1m53s ✗ (exit 1)
_ci-setup 35s
ci::install 5s

Pool status (8 boxes)

box location state
kolu-ci-1 dev-x86-64-linux-04 ✓ idle
kolu-ci-2 dev-x86-64-linux-04 ✓ idle
kolu-ci-3 dev-x86-64-linux-03 ✓ idle
kolu-ci-4 dev-x86-64-linux-08 ✓ idle
kolu-ci-5 idliv2-02 ✓ idle
kolu-ci-6 dev-x86-64-linux-03 ✓ idle
kolu-ci-7 dev-x86-64-linux-05 ✓ idle
kolu-ci-8 dev-x86-64-linux-08 ✓ idle

Posted by ci/pu/report.sh. Lane timings from .ci/fb0ede8/timings.jsonl; pool state is a live flock probe.

@srid srid merged commit 49db1f9 into master Jun 17, 2026
30 checks passed
@srid srid deleted the deps/merge-vite-dompurify-astro branch June 17, 2026 15:16
srid added a commit that referenced this pull request Jun 18, 2026
…3 still excluded (#1397)

Consolidates the remaining open Dependabot bumps into one PR — a single
CI run and one regenerated Nix pnpm-deps hash, the same pattern as
#1394.

## Bumps

| PR | Package | From → To | Scope | Status |
|----|---------|-----------|-------|--------|
| #1396 | `ws` | 8.20.1 → **8.21.0** | root workspace (`server` +
surface examples) | ✅ included |
| #1395 | `astro` | 6.1.10 → **6.4.8** (`^6.4.6`) | `docs/atlas`
(standalone) | ✅ included |
| #1393 | `vite` (dev) | 6.4.2 → 6.4.3 | root workspace | ❌ **excluded**
|

## Why vite 6.4.3 is still excluded

#1394 dropped vite 6.4.3 because its client bundle **deterministically
breaks** the `render_recovery` e2e scenario ("Regaining window focus
repaints a render-stalled terminal", #1381) on **x86_64-linux** — failed
4/4 attempts on a warm CI box; darwin passes. That interaction is still
unresolved, so vite stays pinned at 6.4.2. #1393 should be re-attempted
only once the vite ↔ `render_recovery` interaction is fixed.

## Nix hash

- `ws` touches the root workspace lockfile. The surface examples
(`base.nix` and friends) reuse the root `pnpmDeps`, so **only the root
`default.nix` `fetchPnpmDeps` hash changed**:
`sha256-7damxI1mQ2xbZpDO5NvE8mmPGjyAuck3nybEBsaDUT4=`.
- Regenerated by forcing a re-fetch (the FOD won't re-run on an
unchanged declared hash); full `nix build .#default` is green afterward.
- `website/default.nix` is untouched (its astro was already bumped in
#1394).

## docs/atlas

`docs/atlas` is a standalone project — its own `pnpm-lock.yaml`, **no
`default.nix`** (not Nix-built). Its lockfile was regenerated and
`docs/atlas/dist/` rebuilt + committed (the only delta is the `<meta
generator>` string moving `Astro v6.4.3` → `v6.4.8` across all 41 pages)
so the `ci::atlas-sync` gate stays green.

Closes #1396
Closes #1395

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant