fix(agent): eval awaits async expressions instead of returning the pending Promise (#177) - #196
Merged
Merged
Conversation
…nding Promise (#177) cmdEval sent Runtime.evaluate with returnByValue only, so an async expression came back as the unresolved Promise object and the value was lost. Pass awaitPromise:true — the same flag the HTTP /evaluate route and cmdHeaders/cmdAudit already use — so CDP resolves the promise before serializing. One-line fix; the v0.5.x line needs the same line when the release lines reunify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177.
cmdEvalsentRuntime.evaluatewithreturnByValueonly, so an async expression returned the pending Promise and the resolved value was lost. This passesawaitPromise:true— the same flag the HTTP/evaluateroute andcmdHeaders/cmdAuditalready pass — so CDP resolves before serializing. 378/378 tests pass. Note: the v0.5.x release line has the identical missing flag at its own cmdEval and needs this same one-liner when the lines reunify.