Skip to content

fix: LunaTVSource v0.4.48 - #1189

Open
OneBigMoon wants to merge 1 commit into
jxxghp:mainfrom
OneBigMoon:codex/lunatvsource-0.4.48
Open

fix: LunaTVSource v0.4.48#1189
OneBigMoon wants to merge 1 commit into
jxxghp:mainfrom
OneBigMoon:codex/lunatvsource-0.4.48

Conversation

@OneBigMoon

@OneBigMoon OneBigMoon commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

变更\n\n- LunaTV 资源在 MoviePilot 下载目录校验前进入插件内部串行队列,修复配置了插件目录仍无法下载的问题\n- N_m3u8DL-RE 使用解析后的 ffmpeg 绝对路径,保持 16 线程引擎,不再因裸路径意外回退\n- 受管引擎包临时连接失败最多重试 3 次,HTTP 确定性错误不重试\n- 版本统一升级到 0.4.48,并补充官方目录结构下的回归测试\n\n## 验证\n\n- 302 passed:tests/v3/lunatvsource\n- 24 passed:V3 依赖、发布目录与发布门禁\n- Python 编译与 git diff --check 通过\n- 独立插件仓完整回归:296 passed\n- 真实公开电影完整链路命中 N_m3u8DL-RE 16 线程,未进入 VSD 或 ffmpeg 回退

PR-Agent 摘要

🤖 Generated by PR Agent at 0ec3ff9

  • 下载事件提前接管 LunaTV 任务
  • 配置目录后进入插件串行队列
  • 解析 ffmpeg 路径保障引擎
  • 临时连接失败重试三次
  • 补充队列、路径与重试测试
  • 升级 LunaTVSource 至 0.4.48

MoviePilot validates host download directories before the plugin module runs, so LunaTV resources must enter the internal queue from the resource event.

Resolve ffmpeg to an absolute path before N_m3u8DL-RE so the managed 16-thread engine does not fall back.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR-Agent Code Review

该 PR 将 LunaTV 资源提前送入插件串行队列,并为受管引擎增加连接重试和 ffmpeg 路径解析,同时升级发布版本。当前存在两处中等风险回归:发布元数据仍不一致,且成功接管的下载会被宿主按取消处理,影响发布校验及任务状态与历史记录。

审查提交:0ec3ff9

"name": "moviepilot-lunatvsource-plugin",
"private": true,
"version": "0.4.47",
"version": "0.4.48",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

版本失配

package.json 已升级到 0.4.48,但本 PR 未同步 package-lock.json;基线测试原本明确校验锁文件版本为 0.4.47,因此运行新增的一致性断言时会出现 0.4.470.4.48 冲突,违反各发布清单和锁文件版本必须一致的约束。修正范围仅需同步锁文件的根版本及 packages[""].version

if task_id
else "LunaTV 下载任务未入队,继续交由 MoviePilot 处理"
)
if task_id:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

状态误报

配置了 download_rootdownload() 成功返回 task_id 时,这里会设置 event_data.cancel = True。被删除的原实现注释已记录宿主会把该取消状态解释为“任务添加失败”并跳过原生下载历史,因此任务虽然进入插件队列,订阅链和用户侧仍会收到失败结果,违反成功入队应反馈成功并保留下载记录的契约。修正范围应限于成功接管后的宿主结果映射:阻止后续目录校验时仍需按事件协议返回成功任务标识或补齐等价历史。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant